Do not allow inner hits that fetch _source and have a non nested object field as parent #25749
Conversation
|
I think it could break quite a number of users? I'm wondering whether we should do the check at search time instead only in the case that the field is mapped as an object and is stored in the source as an array? |
martijnvg
force-pushed
the
nested_inner_hits_do_not_allow_object_field
branch
from
f25bf42 to
ece0e47
Compare
|
@jpountz I moved the check to fetch phase. This basically means that we throw |
martijnvg
force-pushed
the
nested_inner_hits_do_not_allow_object_field
branch
from
ece0e47 to
7cf26f4
Compare
| throw new IllegalArgumentException("Cannot execute inner hits. One or more parent object fields of nested field [" + | ||
| nestedObjectMapper.name() + "] are not nested. All parent fields need to be nested fields too"); | ||
| } | ||
| sourceAsMap = (Map<String, Object>) nestedParsedSource.get(nested.getOffset()); |
There was a problem hiding this comment.
You are only checking the first one, but I think we need to iterate over entries from 0 to nested.getOffset() ?
There was a problem hiding this comment.
When the parent object is not nested then XContentMapValues.extractValue(...) extracts the values from two or more layers resulting in a list of list being returned, because there is one nested level, but in the _source there are two ore more levels. This is why I think only the first element of nestedParsedSource needs to be checked. Checking upto nested.getOffset() will likely cause an AOBE.
I'll add a comment explaining that.
martijnvg
force-pushed
the
nested_inner_hits_do_not_allow_object_field
branch
from
7cf26f4 to
20ba983
Compare
…ested object field as parent Closes elastic#25315
a better error message instead of an AOBE and not adding more restrictions.
martijnvg
force-pushed
the
nested_inner_hits_do_not_allow_object_field
branch
from
20ba983 to
6c46a67
Compare
clintongormley
added
:Search/Search
The nested source fetch logic can't properly select the part of the source that belongs to a specific nested document if a nested object field's parent object field is non nested.
PR for #25315