Build: Fork javac to avoid GC overhead #26047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling all of elasticsearch classes in one jvm, which is shared with all of the loaded classes of gradle, can trip gc overhead limits. This commit re-enables forking javac.
bleskes
approved these changes
Aug 3, 2017
|
Note this was originally removed in #25859 under the assumption the forking was only there to allow gradle java to be different from compile/test java. |
rjernst
added a commit
that referenced
this pull request
Aug 3, 2017
Compiling all of elasticsearch classes in one jvm, which is shared with all of the loaded classes of gradle, can trip gc overhead limits. This commit re-enables forking javac.
rjernst
added a commit
that referenced
this pull request
Aug 3, 2017
Compiling all of elasticsearch classes in one jvm, which is shared with all of the loaded classes of gradle, can trip gc overhead limits. This commit re-enables forking javac.
rjernst
added a commit
that referenced
this pull request
Aug 3, 2017
Compiling all of elasticsearch classes in one jvm, which is shared with all of the loaded classes of gradle, can trip gc overhead limits. This commit re-enables forking javac.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling all of elasticsearch classes in one jvm, which is shared with
all of the loaded classes of gradle, can trip gc overhead limits. This
commit re-enables forking javac.