Skip to content

Calculate once the number of machine cores #26070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hanbj
Copy link
Contributor

@hanbj hanbj commented Aug 5, 2017

1、When building the FixedExecutorBuilder and AutoQueueAdjustingExecutorBuilder instance, the parameter availableProcessors is passed in the construction method.
2、numberOfProcessors: There is no need to calculate the number of machine cores again.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@hanbj hanbj changed the title Calculate once Calculate once the number of machine cores Aug 5, 2017
@dakrone dakrone self-requested a review August 6, 2017 19:40
@jasontedor
Copy link
Member

This code should remain as-is. It's clearer this way, and it does not rely on the defaults being equal to the number of available processors.

@jasontedor jasontedor closed this Aug 7, 2017
@hanbj
Copy link
Contributor Author

hanbj commented Aug 7, 2017

@jasontedor Thank you for your review. Please review the #26068. I'm sure it has a logical problem. Thank you.

@jasontedor
Copy link
Member

@hanbj I think that it's already getting attention.

@hanbj hanbj deleted the threadpool branch January 16, 2019 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants