Deprecate global_ordinals_hash and global_ordinals_low_cardinality #26173
Conversation
There was a problem hiding this comment.
I have mixed feelings about this PR. On the one hand I like it because I'd like users to never have to care about the execution mode, but on the other hand this PR moves part of the decision process from the factory to the aggregator, which feels wrong to me, and reduces testing coverage since we cannot force some execution modes anymore.
| deprecationLogger.deprecated("global_ordinals_hash is deprecated. Please use [global_ordinals] instead."); | ||
| return GLOBAL_ORDINALS; | ||
| } else if ("map".equals(value)) { | ||
| return MAP; |
isn't it the opposite ? The factory now picks global ordinals execution with remapping or plain ordinals with the same heuristic than before. I removed the late decision in the aggregator and replaced it with #26014. The aggregator is just able to remap or not based on the decision made in the factory. |
|
Woops, I got a bit lost in the diff and misread your PR, sorry. This change is actually great the way it is. Thanks! +1 to add tests to |
This change deprecates the `global_ordinals_hash` and `global_ordinals_low_cardinality` and makes the `global_ordinals` execution hint choose internally if global ords should be remapped or use the segment ord directly. These hints are too sensitive and expert to be exposed and we should be able to take the right decision internally based on the agg tree.
jimczi
force-pushed
the
global_ordinals_hint
branch
from
91a37a9 to
96becf6
Compare
…26173) * Deprecate global_ordinals_hash and global_ordinals_low_cardinality This change deprecates the `global_ordinals_hash` and `global_ordinals_low_cardinality` and makes the `global_ordinals` execution hint choose internally if global ords should be remapped or use the segment ord directly. These hints are too sensitive and expert to be exposed and we should be able to take the right decision internally based on the agg tree.
…ity exeuction hint deprecated in 6.1
This change deprecates the
global_ordinals_hashandglobal_ordinals_low_cardinalityandmakes the
global_ordinalsexecution hint choose internally if global ords should be remapped or use the segment ord directly.These hints are too sensitive and expert to be exposed and we should be able to take the right decision internally based on the agg tree.
Relates #26014