Skip to content

[DOCS] improve encrypted communication example in java REST low-level client docs #26705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2017
Merged

[DOCS] improve encrypted communication example in java REST low-level client docs #26705

merged 1 commit into from
Sep 25, 2017

Conversation

javanna
Copy link
Member

@javanna javanna commented Sep 19, 2017

Include SSLContext creation and add the missing "https" scheme to the host creation.

Relates to #26534
Closes #26670

@javanna
[DOCS] improve encrypted communication example in java REST low-level…
a6c1876 
… client docs

Include SSLContext creation and add the missing "https" scheme to the host creation.

Relates to elastic#26534
Closes elastic#26670
@javanna javanna requested a review from jaymode September 19, 2017 09:46
nik9000
nik9000 approved these changes Sep 19, 2017
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fixes the docs which is good and we should merge it.

I think we should have a followup where we move this test to a qa module that spins up a ssl supporting proxy.

@colings86 colings86 added v5.6.3 and removed v5.6.2 labels Sep 21, 2017
@javanna javanna merged commit 25f154b into elastic:master Sep 25, 2017
javanna added a commit that referenced this pull request Sep 25, 2017
@javanna
[DOCS] improve encrypted communication example in java REST low-level…
782424a 
… client docs (#26705)

Include SSLContext creation and add the missing "https" scheme to the host creation.

Relates to #26534
Closes #26670
javanna added a commit that referenced this pull request Sep 25, 2017
@javanna
[DOCS] improve encrypted communication example in java REST low-level…
1654d87 
… client docs (#26705)

Include SSLContext creation and add the missing "https" scheme to the host creation.

Relates to #26534
Closes #26670
javanna added a commit that referenced this pull request Sep 25, 2017
@javanna
[DOCS] improve encrypted communication example in java REST low-level…
f881919 
… client docs (#26705)

Include SSLContext creation and add the missing "https" scheme to the host creation.

Relates to #26534
Closes #26670
@javanna javanna mentioned this pull request Sep 25, 2017
Closed
@lcawl lcawl removed the v6.1.0 label Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

@jaymode jaymode jaymode approved these changes

Assignees
No one assigned
Labels
>docs General docs changes v5.0.3 v5.1.3 v5.2.3 v5.3.3 v5.4.4 v5.5.4 v5.6.3 v6.0.0-rc1 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@javanna @nik9000 @jaymode @colings86 @lcawl