Replace group map settings with affix setting #26819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use group settings historically instead of using a prefix setting which
is more restrictive and type safe. The majority of the usecases needs to access
a key, value map based on the _leave node_ of the setting ie. the setting
`index.tag.*` might be used to tag an index with `index.tag.test=42` and
`index.tag.staging=12` which then would be turned into a `{"test": 42, "staging": 12}`
map. The group settings would always use `Settings#getAsMap` which is loosing type information
and uses internal respesentation of the settings. Using prefix settings allows now to
access such a method typesafe and natively.
s1monw
added
:Core/Infra/Settings
rjernst
approved these changes
Sep 28, 2017
| @@ -577,6 +577,16 @@ public void testAffixKeySetting() { | |||
| assertFalse(listAffixSetting.match("foo")); | |||
| } | |||
|
|
|||
| public void testAffixAsMap() { | |||
There was a problem hiding this comment.
Can you add a test for what happens if there are further subkeys? eg foo.bar.baz.deep
s1monw
added a commit
that referenced
this pull request
Sep 30, 2017
We use group settings historically instead of using a prefix setting which is
more restrictive and type safe. The majority of the usecases needs to access a
key, value map based on the _leave node_ of the setting ie. the setting
`index.tag.*` might be used to tag an index with `index.tag.test=42` and
`index.tag.staging=12` which then would be turned into a `{"test": 42,
"staging": 12}` map. The group settings would always use `Settings#getAsMap`
which is loosing type information and uses internal representation of the
settings. Using prefix settings allows now to access such a method type-safe and
natively.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 1, 2017
* xdcr: Maybe die before trying to log cause Log cause when a write and flush fails Die if write listener fails due to fatal error RecoveryIT.testHistoryUUIDIsGenerated should reduce unassigned shards delay instead of ensure green. Replace group map settings with affix setting (elastic#26819) Fix references to vm.max_map_count in Docker docs Add more instructions about jar hell (elastic#26837) Forbid negative values for index.unassigned.node_left.delayed_timeout (elastic#26828) Nitpicking typos in comments (elastic#26831) MetaData Builder doesn't properly prevent an alias with the same name as an index (elastic#26804)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use group settings historically instead of using a prefix setting which
is more restrictive and type safe. The majority of the usecases needs to access
a key, value map based on the leave node of the setting ie. the setting
index.tag.*might be used to tag an index withindex.tag.test=42andindex.tag.staging=12which then would be turned into a{"test": 42, "staging": 12}map. The group settings would always use
Settings#getAsMapwhich is loosing type informationand uses internal respesentation of the settings. Using prefix settings allows now to
access such a method typesafe and natively.