Allocation: add delay between retries for failed allocations #27086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a failed allocation was retried in a tight loop that filled up log files and caused the cluster be unstable. We solved this problem by limiting the number of retries. However, this solution requires manual intervention when the environment is adjusted. This PR aims to reduce user intervention by increasing the number of retries and adding some exponential backoff delays between retries. Closes elastic#24530
|
@jasontedor, this solution may not be what we want but please review and give me some feedbacks. Thank you. |
|
@ywelsch Would you please review? |
|
I think the backoff should be happening on a per-shard basis (which does not seem to be case in this PR). I'll reach out to discuss. |
|
Closing as the approach in this PR is not good. |
lcawl
added
:Search/Search
clintongormley
added
:Distributed Indexing/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a failed allocation was retried in a tight loop that filled
up log files and caused the cluster be unstable. We solved this problem
by limiting the number of retries. However, this solution requires
manual intervention when the environment is adjusted. This PR aims to
reduce user intervention by increasing the number of retries and adding
some exponential backoff delays between retries.
Closes #24530