-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Fail restore when the shard allocations max retries count is reached #27493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tlrx
merged 12 commits into
elastic:master
from
tlrx:fail-restore-on-max-retries-allocations
Dec 12, 2017
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
45113a4
Fail restore when the shard allocations max retries count is reached
tlrx 57309a5
Apply feedback
tlrx 02c5be9
Add test
tlrx 40ed380
Apply feedback
tlrx fb98ee8
add RestoreInProgressAllocationDecider
tlrx 6a16d4c
Fix license
tlrx e2968d4
Fix ClusterModuleTests
tlrx c0eb88b
Adapt SharedClusterSnapshotRestoreIT.testDataFileFailureDuringRestore
tlrx a7cce84
Apply feedback
tlrx 5afed33
Remove assertion
tlrx 29bc625
Update ThrottlingAllocationTests
tlrx 8ced615
Update assertion message
tlrx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 changes: 86 additions & 0 deletions
86
.../elasticsearch/cluster/routing/allocation/decider/RestoreInProgressAllocationDecider.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| /* | ||
| * Licensed to Elasticsearch under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.elasticsearch.cluster.routing.allocation.decider; | ||
|
|
||
| import org.elasticsearch.cluster.RestoreInProgress; | ||
| import org.elasticsearch.cluster.routing.RecoverySource; | ||
| import org.elasticsearch.cluster.routing.RoutingNode; | ||
| import org.elasticsearch.cluster.routing.ShardRouting; | ||
| import org.elasticsearch.cluster.routing.allocation.RoutingAllocation; | ||
| import org.elasticsearch.common.settings.Settings; | ||
| import org.elasticsearch.snapshots.Snapshot; | ||
|
|
||
| /** | ||
| * This {@link AllocationDecider} prevents shards that have failed to be | ||
| * restored from a snapshot to be allocated. | ||
| */ | ||
| public class RestoreInProgressAllocationDecider extends AllocationDecider { | ||
|
|
||
| public static final String NAME = "restore_in_progress"; | ||
|
|
||
| /** | ||
| * Creates a new {@link RestoreInProgressAllocationDecider} instance from | ||
| * given settings | ||
| * | ||
| * @param settings {@link Settings} to use | ||
| */ | ||
| public RestoreInProgressAllocationDecider(Settings settings) { | ||
| super(settings); | ||
| } | ||
|
|
||
| @Override | ||
| public Decision canAllocate(final ShardRouting shardRouting, final RoutingNode node, final RoutingAllocation allocation) { | ||
| return canAllocate(shardRouting, allocation); | ||
| } | ||
|
|
||
| @Override | ||
| public Decision canAllocate(final ShardRouting shardRouting, final RoutingAllocation allocation) { | ||
| final RecoverySource recoverySource = shardRouting.recoverySource(); | ||
| if (recoverySource == null || recoverySource.getType() != RecoverySource.Type.SNAPSHOT) { | ||
| return allocation.decision(Decision.YES, NAME, "ignored as shard is not being recovered from a snapshot"); | ||
| } | ||
|
|
||
| final Snapshot snapshot = ((RecoverySource.SnapshotRecoverySource) recoverySource).snapshot(); | ||
| final RestoreInProgress restoresInProgress = allocation.custom(RestoreInProgress.TYPE); | ||
|
|
||
| if (restoresInProgress != null) { | ||
| for (RestoreInProgress.Entry restoreInProgress : restoresInProgress.entries()) { | ||
| if (restoreInProgress.snapshot().equals(snapshot)) { | ||
| RestoreInProgress.ShardRestoreStatus shardRestoreStatus = restoreInProgress.shards().get(shardRouting.shardId()); | ||
| if (shardRestoreStatus != null && shardRestoreStatus.state().completed() == false) { | ||
| assert shardRestoreStatus.state() != RestoreInProgress.State.SUCCESS : "expected shard [" + shardRouting | ||
| + "] to be in initializing state but got [" + shardRestoreStatus.state() + "]"; | ||
| return allocation.decision(Decision.YES, NAME, "shard is currently being restored"); | ||
| } | ||
| break; | ||
| } | ||
| } | ||
| } | ||
| return allocation.decision(Decision.NO, NAME, "shard has failed to be restored from the snapshot [%s] because of [%s] - " + | ||
| "manually close or delete the index [%s] in order to retry to restore the snapshot again or use the reroute API to force the " + | ||
| "allocation of an empty primary shard", snapshot, shardRouting.unassignedInfo().getDetails(), shardRouting.getIndexName()); | ||
| } | ||
|
|
||
| @Override | ||
| public Decision canForceAllocatePrimary(ShardRouting shardRouting, RoutingNode node, RoutingAllocation allocation) { | ||
| assert shardRouting.primary() : "must not call canForceAllocatePrimary on a non-primary shard " + shardRouting; | ||
| return canAllocate(shardRouting, node, allocation); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also add
as this is a hard constraint with no exceptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch