[TEST] Remove leftover ES temp directories before Vagrant tests #27722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the Vagrant tests were failing due to ES temp directories left over from previous uses of the same VM confusing subsequent tests into thinking there were multiple ES installs present. This change wipes all ES temp directories when the test VMs are brought up.
droberts195
added
review
>test
|
An example of a failure this will prevent is https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+packaging-tests/2216/console |
jasontedor
approved these changes
Dec 8, 2017
Vagrantfile
Outdated
| # This prevents leftovers from previous tests using the | ||
| # same VM from messing up the current test | ||
| config.vm.provision "clean_tmp", run: "always", type: "shell", inline: <<-SHELL | ||
| rm -rf /tmp/elastic*earch* |
There was a problem hiding this comment.
Since you fixed the missing s, can we leave this simply as /tmp/elasticsearch? The VMs on CI will eventually be cleaned up when, for example, the boxes are updated?
There was a problem hiding this comment.
Sure, I've changed this
droberts195
added a commit
that referenced
this pull request
Dec 8, 2017
Some of the Vagrant tests were failing due to ES temp directories left over from previous uses of the same VM confusing subsequent tests into thinking there were multiple ES installs present. This change wipes all ES temp directories when the test VMs are brought up.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Dec 8, 2017
* master: (414 commits) Set ACK timeout on indices service test Implement byte array reusage in `NioTransport` (elastic#27696) [TEST] Remove leftover ES temp directories before Vagrant tests (elastic#27722) Cleanup split strings by comma method Remove unused import from AliasResolveRoutingIT Add read timeouts to http module (elastic#27713) Fix routing with leading or trailing whitespace remove await fix from FullClusterRestartIT.testRecovery Add missing 's' to tmpdir name (elastic#27721) [Issue-27716]: CONTRIBUTING.md IntelliJ configurations settings are confusing. (elastic#27717) [TEST] Now actually wait for merges Test out of order delivery of append only index and retry with an intermediate delete [TEST] remove code duplications in RequestTests [Tests] Add test for GeoShapeFieldType#setStrategyName (elastic#27703) Remove unused *Commit* classes (elastic#27714) Add test for writer operation buffer accounting (elastic#27707) [TEST] Wait for merging to complete before testing breaker Add Open Index API to the high level REST client (elastic#27574) Correcting some minor typos in comments Add unreleased v5.6.6 version ...
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Dec 9, 2017
* master: Fix index with unknown setting test Remove internal channel tracking in transports (elastic#27711) Improve error msg when a field name contains only white spaces (elastic#27709) Do not open indices with broken settings Set ACK timeout on indices service test Implement byte array reusage in `NioTransport` (elastic#27696) [TEST] Remove leftover ES temp directories before Vagrant tests (elastic#27722) Cleanup split strings by comma method Remove unused import from AliasResolveRoutingIT Add read timeouts to http module (elastic#27713) Fix routing with leading or trailing whitespace remove await fix from FullClusterRestartIT.testRecovery Add missing 's' to tmpdir name (elastic#27721) [Issue-27716]: CONTRIBUTING.md IntelliJ configurations settings are confusing. (elastic#27717) [TEST] Now actually wait for merges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the Vagrant tests were failing due to ES temp directories
left over from previous uses of the same VM confusing subsequent
tests into thinking there were multiple ES installs present.
This change wipes all ES temp directories when the test VMs are
brought up.