Fix third-party audit tasks on JDK 8 #28256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one is interesting. The third party audit task runs inside the Gradle JVM. This means that if Gradle is started on JDK 8, the third party audit tasks will fail as a result of the changes to support building Elasticsearch with the JDK 9 compiler. This commit reverts the third party audit changes to support running this task when Gradle is started with JDK 8.
jasontedor
added
review
:Delivery/Build
jasontedor
added a commit
that referenced
this pull request
Jan 17, 2018
This one is interesting. The third party audit task runs inside the Gradle JVM. This means that if Gradle is started on JDK 8, the third party audit tasks will fail as a result of the changes to support building Elasticsearch with the JDK 9 compiler. This commit reverts the third party audit changes to support running this task when Gradle is started with JDK 8. Relates #28256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is interesting. The third party audit task runs inside the Gradle JVM. This means that if Gradle is started on JDK 8, the third party audit tasks will fail as a result of the changes to support building Elasticsearch with the JDK 9 compiler. This commit reverts the third party audit changes to support running this task when Gradle is started with JDK 8.
Relates #28252