Remove NioNotEnabledBootstrapCheck bootstrap check #28901
Conversation
This is related to elastic#27260. This commit adds a setting that will override the nio not enabled bootstrap check. This will be necessary as the bootstrap check would interfere with benchmarking or any production-similar testing.
Tim-Brooks
added
>non-issue
review
:Distributed Coordination/Network
Tim-Brooks
requested review from
s1monw,
jaymode,
danielmitterdorfer and
jasontedor
| @@ -21,12 +21,23 @@ | |||
|
|
|||
| import org.elasticsearch.bootstrap.BootstrapCheck; | |||
| import org.elasticsearch.bootstrap.BootstrapContext; | |||
| import org.elasticsearch.common.settings.Setting; | |||
| import org.elasticsearch.common.util.concurrent.EsExecutors; | |||
There was a problem hiding this comment.
Nit: I think this import should not be needed?
|
|
||
| public class NioNotEnabledBootstrapCheck implements BootstrapCheck { | ||
|
|
||
| public static final Setting<Boolean> OVERRIDE_BOOTSTRAP = |
There was a problem hiding this comment.
Tbh, I was not sure whether a system property or a setting would be a better choice but using a setting for this is consistent with what we did previously (see e.g. #20511).
|
|
||
| public class NioNotEnabledBootstrapCheck implements BootstrapCheck { | ||
|
|
||
| public static final Setting<Boolean> OVERRIDE_BOOTSTRAP = | ||
| boolSetting("transport.nio.override_nio_bootstrap_check", false, Setting.Property.NodeScope); |
There was a problem hiding this comment.
Alternatively bootstrap.ignore_transport_nio_bootstrap_checks?
|
Is this bootstrap check still needed? Can we remove it and only add it back if we decide NIO is not ready for production usage before 7.0.0? |
|
@jasontedor I think that is a question for @s1monw. He asked me to add the bootstrap check in one of my past PRs. |
|
Sure thing let us wait for @s1monw, it's impotent though once there is a flag to skip it. |
++ just remove it for now |
Tim-Brooks
changed the title
Tim-Brooks
changed the title
This is related to elastic#27260. This commit removes the bootstrap check that prevents nio from being enabled.
This is related to #27260. This commit removes the bootstrap check that
prevents nio from being enabled.