added docs for wrapper query
#29049
Merged
added docs for wrapper query
#29049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra |
javanna
reviewed
Mar 14, 2018
| @@ -18,9 +18,14 @@ This query allows a script to act as a filter. Also see the | |||
|
|
|||
| This query finds percolator queries based on documents. | |||
|
|
|||
| <<query-dsl-wrapper-query,`wrapper` query>>:: | |||
|
|
|||
| A query that accepts other queries as json string. | |||
There was a problem hiding this comment.
this one doesn't only support json right? also yaml etc.?
javanna
reviewed
Mar 14, 2018
|
|
||
| This query is more useful in the context of the high level rest client or | ||
| transport client. In these cases queries can be specified as a json or | ||
| yaml formatted string or as native query builder. |
There was a problem hiding this comment.
what do you mean here with "native query builder"?
javanna
reviewed
Mar 14, 2018
|
|
||
| <1> Base64 encoded string: `{"term" : { "user" : "Kimchy" }}` | ||
|
|
||
| This query is more useful in the context of the high level rest client or |
There was a problem hiding this comment.
nit: s/high level rest client/high-level REST client ?
Maybe explain why it would be useful?
javanna
approved these changes
Mar 14, 2018
There was a problem hiding this comment.
left a couple of nits, thanks @martijnvg for addressing this!
martijnvg
force-pushed
the
docs_wrapper_query
branch
2 times, most recently
from
dbc8835 to
594faef
Compare
martijnvg
force-pushed
the
docs_wrapper_query
branch
from
594faef to
1cae090
Compare
martijnvg
force-pushed
the
docs_wrapper_query
branch
from
1cae090 to
34a264c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11591