Skip to content

Protect against NPE in RestNodesAction #29059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2018
Merged

Protect against NPE in RestNodesAction #29059

merged 2 commits into from
Mar 14, 2018

Conversation

davidkyle
Copy link
Member

fsInfo may be null but not all the the code that accesses it is guarded by a null check.

@davidkyle davidkyle added >bug :Core/Infra/REST API REST infrastructure and utilities v7.0.0 v6.3.0 labels Mar 14, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @davidkyle !

@jasontedor
Copy link
Member

I am curious how the null fsInfo arises?

@davidkyle davidkyle merged commit cb9d10f into elastic:master Mar 14, 2018
davidkyle added a commit that referenced this pull request Mar 14, 2018
* Protect against NPE in RestNodesAction
@davidkyle davidkyle deleted the fix-rest-nodes-action branch April 4, 2018 14:16
jasontedor added a commit that referenced this pull request Apr 18, 2018
* Protect against NPE in RestNodesAction
jasontedor pushed a commit that referenced this pull request Apr 18, 2018
* Protect against NPE in RestNodesAction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants