Add useful message when no input from terminal #29369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today when a user runs a CLI tool with standard input closed and no tty attached, the result from reading is null and this usually leads to a null pointer exception when we try to parse this input. This arises for example when the user runs the plugin installer through a Docker container without leaving standard input open and attaching a tty (docker exec <container ID> bin/elasticsearch-plugin install). When we try to read that the user accepts the plugin requiring additional security permissions we will get back null. This commit addresses this for all cases by throwing an illegal state exception. The solution for the user is leave standard input open and attach a tty (or, for some tools, use batch mode).
jasontedor
added
review
:Core/Infra/Core
|
Now, a user would see: |
jasontedor
added a commit
that referenced
this pull request
Apr 11, 2018
Today when a user runs a CLI tool with standard input closed and no tty attached, the result from reading is null and this usually leads to a null pointer exception when we try to parse this input. This arises for example when the user runs the plugin installer through a Docker container without leaving standard input open and attaching a tty (docker exec <container ID> bin/elasticsearch-plugin install). When we try to read that the user accepts the plugin requiring additional security permissions we will get back null. This commit addresses this for all cases by throwing an illegal state exception. The solution for the user is leave standard input open and attach a tty (or, for some tools, use batch mode).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today when a user runs a CLI tool with standard input closed and no tty attached, the result from reading is null and this usually leads to a null pointer exception when we try to parse this input. This arises for example when the user runs the plugin installer through a Docker container without leaving standard input open and attaching a tty (docker exec bin/elasticsearch-plugin install). When we try to read that the user accepts the plugin requiring additional security permissions we will get back null. This commit addresses this for all cases by throwing an illegal state exception. The solution for the user is leave standard input open and attach a tty (or, for some tools, use batch mode).
Relates #29359, relates #29365