Skip to content

Remove usage of transient settings to enable allocations in rolling upgrade docs #29671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2018
Merged

Remove usage of transient settings to enable allocations in rolling upgrade docs #29671

merged 2 commits into from
May 1, 2018

Conversation

bleskes
Copy link
Contributor

@bleskes bleskes commented Apr 24, 2018 •
edited
Loading

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will leed for shards
not being allocated.

Relates to #28757

@bleskes
Remove usage of transient settings to enable allocations in rolling u…
78f401c 
…pgrade docs

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will leed for shards
not being allocated.

Relates to elastic#28757
@colings86 colings86 added >docs General docs changes :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. labels Apr 24, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

ywelsch
ywelsch approved these changes Apr 24, 2018
View reviewed changes
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (one nit)

docs/reference/upgrade/rolling_upgrade.asciidoc Outdated
Once the node has joined the cluster, reenable shard allocation to start using
the node:
Once the node has joined the cluster, remove the `cluster.routing.allocation.enable`
settings to enable shard allocation and start using the node:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/settings/setting

@DaveCTurner DaveCTurner mentioned this pull request Apr 30, 2018
Closed
@bleskes bleskes merged commit 9a89299 into elastic:6.2 May 1, 2018
@bleskes bleskes deleted the patch-2 branch May 1, 2018 13:51
@bleskes
Copy link
Contributor Author

bleskes commented May 1, 2018

thanks @ywelsch

bleskes added a commit that referenced this pull request May 1, 2018
@bleskes
Remove usage of transient settings to enable allocations in rolling u…
939a4f5 
…pgrade docs (#29671)

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will lead for shards
not being allocated.

Relates to #28757
bleskes added a commit that referenced this pull request May 1, 2018
@bleskes
Remove usage of transient settings to enable allocations in rolling u…
5c6a57a 
…pgrade docs (#29671)

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will lead for shards
not being allocated.

Relates to #28757
bleskes added a commit that referenced this pull request May 1, 2018
@bleskes
Remove usage of transient settings to enable allocations in rolling u…
f4901b8 
…pgrade docs (#29671)

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will lead for shards
not being allocated.

Relates to #28757
@DaveCTurner DaveCTurner mentioned this pull request Aug 24, 2018
Closed
danielmitterdorfer pushed a commit that referenced this pull request Jan 30, 2019
@bleskes @danielmitterdorfer
Remove usage of transient settings to enable allocations in rolling u…
728013a 
…pgrade docs (#29671)

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will lead for shards
not being allocated.

Relates to #28757
@danielmitterdorfer danielmitterdorfer mentioned this pull request Jan 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywelsch ywelsch ywelsch approved these changes

Assignees
No one assigned
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. >docs General docs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bleskes @elasticmachine @ywelsch @colings86