[Test] Update test in SharedClusterSnapshotRestoreIT #30200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `testDeleteSnapshotWithMissingIndexAndShardMetadata` test uses an obsolete repository directory structure based on index names instead of UUIDs. Because it swallows exceptions when deleting test files the test never failed when the directory structure changed. This commit fixes the test to use the right directory structure and file names and to not swallow exceptions anymore.
tlrx
added
>test
|
Pinging @elastic/es-distributed |
|
@elasticmachine test this please |
tlrx
added a commit
that referenced
this pull request
Apr 30, 2018
The `testDeleteSnapshotWithMissingIndexAndShardMetadata` test uses an obsolete repository directory structure based on index names instead of UUIDs. Because it swallows exceptions when deleting test files the test never failed when the directory structure changed. This commit fixes the test to use the right directory structure and file names and to not swallow exceptions anymore.
|
Thanks @ywelsch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
testDeleteSnapshotWithMissingIndexAndShardMetadatatest uses anobsolete repository directory structure based on index names instead of
UUIDs. Because it swallows exceptions when deleting test files the test
never failed when the directory structure changed.
This commit fixes the test to use the right directory structure and file
names and to not swallow exceptions anymore.