SQL: Verify GROUP BY ordering on grouped columns #30585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the way composite aggregation works, ordering in GROUP BY can be applied only through grouped columns which now the analyzer verifier enforces. Fix 29900
|
Pinging @elastic/es-search-aggs |
nik9000
approved these changes
May 15, 2018
costin
added a commit
that referenced
this pull request
May 15, 2018
Due to the way composite aggregation works, ordering in GROUP BY can be applied only through grouped columns which now the analyzer verifier enforces. Fix 29900
costin
added a commit
to costin/elasticsearch
that referenced
this pull request
May 15, 2018
Due to the way composite aggregation works, ordering in GROUP BY can be applied only through grouped columns which now the analyzer verifier enforces. Fix 29900
This was referenced May 15, 2018
|
Ran into this today, and tried this as a workaround: SELECT *
FROM (
SELECT app.name, SUM(duration) AS total_duration
FROM qbserve
WHERE category.productivity = 1
GROUP BY app.name
)
ORDER BY total_duration DESCDidn't get an error, but the results also weren't sorted. 🤷♂️ Does this mean this is still an issue? |
For the posterity: no, besides grouped field, ordering by an agg function (like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way composite aggregation works, ordering in GROUP BY can be
applied only through grouped columns which now the analyzer verifier
enforces.
Fix #29900