Skip to content

Delete typos in SAML docs #31199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/docs/en/security/authentication/saml-guide.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ attribute.groups:: See <<saml-attribute-mapping>>.
When a user connects to {kib} through your Identity Provider, the Identity
Provider will supply a SAML Assertion about the user. The assertion will contain
an _Authentication Statement_ indicating that the user has successfully
authenticated to the IdP and one ore more _Attribute Statements_ that will
authenticated to the IdP and one or more _Attribute Statements_ that will
include _Attributes_ for the user.

These attributes may include such things as:
Expand All @@ -213,7 +213,7 @@ customise the URIs and their associated value.
logged in, and they can be used for role mapping (below).

In order for these attributes to be useful, {es} and the IdP need to have a
common via for the names of the attributes. This is done manually, by
common value for the names of the attributes. This is done manually, by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what I was trying to write here, but value seems like a good enough guess.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what I was trying to write here

common view maybe ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. I considered that, but I think I would have written view of rather than view for.
🤷‍♂️

configuring the IdP and the {security} SAML realm to use the same URI name for
each logical user attribute.

Expand Down