Deprecate dots in aggregation names #31468
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dots in aggregation names can lead to tricky parsing situations, like being unable to sort by agg names with dots. This adds a deprecation logger and a note in the docs, letting us remove them in 8.0. Related to elastic#17600 and elastic#19040
polyfractal
added
review
:Analytics/Aggregations
|
Pinging @elastic/es-search-aggs |
|
Given that 7.0 is still a long way out, why isn't the deprecation intended for 6.4 long enough to remove in 7.0? Waiting until 8.0 is a very long time. |
|
The thinking was that it's a relatively low-priority deprecation (cleans things up, but isn't necessarily blocking anything), but might affect a lot of users. So someone upgrading directly from 6.3 to 7.0 wouldn't see the deprecations and would be hit with the break. /cc @jpountz might have some thoughts. |
|
@polyfractal is this still something we should do? |
|
Stale, closing for now. We should probably still do this but I don't have bandwidth at the moment to revisit this. |
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dots in aggregation names can lead to tricky parsing situations, like being unable to sort by agg names with dots. Rather than introducing a lot of complex parsing code, we should just deprecate dots in agg names. This puts them inline with the restrictions on field names too.
This PR adds a deprecation logger and a note in the docs, letting us remove them in 8.0.
It isn't strictly a 7.0 deprecation (I would like to backport it to 6.4), but I thought it made sense to include in the 7.0 migration guide in case people upgrade directly from 6.3 to 7.0
Related to #17600 and #19040