-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Test: Do not remove xpack templates when cleaning #31642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
04f4a18
Test: Do not remove xpack templates when cleaning
nik9000 b7546ef
Explain
nik9000 99950ad
Unused imports
nik9000 db245f4
Merge branch 'master' into speed_x_pack_tests
nik9000 9e16d0b
Fix up comment
nik9000 2b330d3
Merge branch 'master' into speed_x_pack_tests
nik9000 09cffbe
Never try and clean templates named empty string
nik9000 888db57
Fix error catching
nik9000 918cb50
Merge branch 'master' into speed_x_pack_tests
nik9000 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment seems kind of odd for a true/false isXXX method :) It cares not about a delete.