Skip to content

Adds explain lifecycle API to the Rest Client #32606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 9, 2018
Merged

Adds explain lifecycle API to the Rest Client #32606

merged 10 commits into from
Aug 9, 2018

Conversation

colings86
Copy link
Contributor

No description provided.

@colings86 colings86 added the :Data Management/ILM+SLM Index and Snapshot lifecycle management label Aug 3, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@colings86 colings86 changed the title Adds expalin lifecycle API to the Rest Client Adds explain lifecycle API to the Rest Client Aug 3, 2018
@colings86
Copy link
Contributor Author

@elasticmachine test this please

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I left some requests for javadocs on the user-facing portion but no need for another review (once CI is happy)

import java.util.function.Function;
import java.util.stream.Collectors;

public class ExplainLifecycleResponse extends ActionResponse implements ToXContentObject {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add javadocs please?

this.indexResponses = indexResponses;
}

public Map<String, IndexLifecycleExplainResponse> getIndexResponses() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method needs javadocs since I expect it to be user-facing

import java.util.Arrays;
import java.util.Objects;

public class ExplainLifecycleRequest extends ClusterInfoRequest<ExplainLifecycleRequest> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add javadocs please :)


@Override
public String toString() {
return "Request [indices()=" + Arrays.toString(indices()) + ", indicesOptions()=" + indicesOptions() + "]";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request -> ExplainLifecycleRequest

@colings86 colings86 merged commit 5ff4f93 into elastic:index-lifecycle Aug 9, 2018
@colings86 colings86 deleted the ilm/rest-explain branch August 9, 2018 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants