-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Adds explain lifecycle API to the Rest Client #32606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds explain lifecycle API to the Rest Client #32606
Conversation
Pinging @elastic/es-core-infra |
@elasticmachine test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, I left some requests for javadocs on the user-facing portion but no need for another review (once CI is happy)
import java.util.function.Function; | ||
import java.util.stream.Collectors; | ||
|
||
public class ExplainLifecycleResponse extends ActionResponse implements ToXContentObject { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add javadocs please?
this.indexResponses = indexResponses; | ||
} | ||
|
||
public Map<String, IndexLifecycleExplainResponse> getIndexResponses() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method needs javadocs since I expect it to be user-facing
import java.util.Arrays; | ||
import java.util.Objects; | ||
|
||
public class ExplainLifecycleRequest extends ClusterInfoRequest<ExplainLifecycleRequest> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add javadocs please :)
|
||
@Override | ||
public String toString() { | ||
return "Request [indices()=" + Arrays.toString(indices()) + ", indicesOptions()=" + indicesOptions() + "]"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request -> ExplainLifecycleRequest
No description provided.