Skip to content

LOGGING: Upgrade to Log4J 2.11.1 #32616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 6, 2018

Conversation

original-brownbear
Copy link
Contributor

* Upgrade to `2.11.1` to fix memory leaks in slow logger when logging large requests
   * This was caused by a bug in Log4J https://issues.apache.org/jira/browse/LOG4J2-2269 and is fixed in `2.11.1` via https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=9496c0c
* Fixes elastic#32537
* Fixes elastic#27300
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@original-brownbear
Copy link
Contributor Author

looks like the third party audit fails on CI (passed locally) ... will fix in a few hours

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find. LGTM assuming that you get a green PR CI build and have third-party audit passing on JDK 8, JDK 10, and JDK 11. I think that we should backport this to 5.6.11 too.

@jasontedor
Copy link
Member

In fact, I would support merging this to 6.4.0.

@original-brownbear
Copy link
Contributor Author

@jasontedor alrighty got it green :)
Just one trivial change to the tests (that nicely shows that this should fix the problem I think) https://github.com/elastic/elasticsearch/pull/32616/files#diff-d0333c88811865623eb43c70c4e1c14bR49

and conditional excludes to make JDK8 auditing pass.

Can you take another look please? :)

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@original-brownbear
Copy link
Contributor Author

@jasontedor thanks! Merging + back porting then :)

@original-brownbear original-brownbear merged commit 0a67cb4 into elastic:master Aug 6, 2018
@original-brownbear original-brownbear deleted the 32537 branch August 6, 2018 12:56
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Aug 6, 2018
* LOGGING: Upgrade to Log4J 2.11.1
* Upgrade to `2.11.1` to fix memory leaks in slow logger when logging large requests
   * This was caused by a bug in Log4J https://issues.apache.org/jira/browse/LOG4J2-2269 and is fixed in `2.11.1` via https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=9496c0c
* Fixes elastic#32537
* Fixes elastic#27300
original-brownbear added a commit that referenced this pull request Aug 7, 2018
* LOGGING: Upgrade to Log4J 2.11.1
* Upgrade to `2.11.1` to fix memory leaks in slow logger when logging large requests
   * This was caused by a bug in Log4J https://issues.apache.org/jira/browse/LOG4J2-2269 and is fixed in `2.11.1` via https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=9496c0c
* Fixes #32537
* Fixes #27300
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Aug 7, 2018
* LOGGING: Upgrade to Log4J 2.11.1
* Upgrade to `2.11.1` to fix memory leaks in slow logger when logging large requests
   * This was caused by a bug in Log4J https://issues.apache.org/jira/browse/LOG4J2-2269 and is fixed in `2.11.1` via https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=9496c0c
* Fixes elastic#32537
* Fixes elastic#27300
original-brownbear added a commit that referenced this pull request Aug 7, 2018
* LOGGING: Upgrade to Log4J 2.11.1
* Upgrade to `2.11.1` to fix memory leaks in slow logger when logging large requests
   * This was caused by a bug in Log4J https://issues.apache.org/jira/browse/LOG4J2-2269 and is fixed in `2.11.1` via https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=9496c0c
* Fixes #32537
* Fixes #27300
@colings86 colings86 removed the v7.0.0 label Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants