Whitelisting / from Circuit Breaker Exception (#32325) #32666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Circuit Breaker has tripped, certain diagnostic requests like "_cluster/health" succeed where as request to / fails with 503 Service Unavailable. This behavior is observed because of this commit f32b700 where certain API paths are whitelisted from Circuit Breaking exception, but / is not whitelisted. Added / to circuit breaker whitelist so that it can be used for diagnostic purposes
dliappis
added
the
:Core/Infra/Circuit Breakers
|
Pinging @elastic/es-core-infra |
dliappis
added
:Core/Infra/Circuit Breakers
dakrone
approved these changes
Aug 7, 2018
|
@elasticmachine test this please |
|
@elasticmachine test this please |
1 similar comment
|
@elasticmachine test this please |
dakrone
pushed a commit
that referenced
this pull request
Aug 8, 2018
When Circuit Breaker has tripped, certain diagnostic requests like "_cluster/health" succeed where as request to / fails with 503 Service Unavailable. This behavior is observed because of this commit f32b700 where certain API paths are whitelisted from Circuit Breaking exception, but / is not whitelisted. Added / to circuit breaker whitelist so that it can be used for diagnostic purposes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Circuit Breaker has tripped, certain diagnostic requests like
"_cluster/health" succeed where as request to / fails with
503 Service Unavailable. This behavior is observed because of this
commit f32b700 where certain API paths are whitelisted from
Circuit Breaking exception, but / is not whitelisted.
Added / to circuit breaker whitelist so that it can be used for
diagnostic purposes