Set maxScore for empty TopDocs to Nan rather than 0 #32938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to set `maxScore` to `0` within `TopDocs` in situations where there is really no score as the size was set to `0` and scores were not even tracked. In such scenarios, `Float.Nan` is more appropriate, which gets converted to `max_score: null` on the REST layer. That's also more consistent with lucene which set `maxScore` to `Float.Nan` when merging empty `TopDocs` (see `TopDocs#merge`).
javanna
added
>bug
:Search/Search
|
Pinging @elastic/es-search-aggs |
javanna
commented
Aug 17, 2018
| @@ -513,7 +513,7 @@ public void testSearchWithSuggest() throws IOException { | |||
| assertNull(searchResponse.getAggregations()); | |||
| assertEquals(Collections.emptyMap(), searchResponse.getProfileResults()); | |||
| assertEquals(0, searchResponse.getHits().totalHits); | |||
| assertEquals(0f, searchResponse.getHits().getMaxScore(), 0f); | |||
| assertEquals(Float.NaN, searchResponse.getHits().getMaxScore(), 0f); | |||
| assertEquals(0, searchResponse.getHits().getHits().length); | |||
| assertEquals(1, searchResponse.getSuggest().size()); | |||
There was a problem hiding this comment.
I am not too happy that all the failures I got came from integration tests and docs tests. I added some assertions to QueryPhaseTests but maybe that is not enough. Suggestions are welcome on where to add tests for this change.
jpountz
approved these changes
Aug 17, 2018
javanna
force-pushed
the
fix/empty_top_docs_nan
branch
from
c7c637c to
9c19b4b
Compare
|
thanks @jpountz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to set
maxScoreto0withinTopDocsin situations where there is really no score as the size was set to0and scores were not even tracked. In such scenarios,Float.Nanis more appropriate, which gets converted tomax_score: nullon the REST layer. That's also more consistent with lucene which setmaxScoretoFloat.Nanwhen merging emptyTopDocs(seeTopDocs#merge).