HLRC: Add Get Lifecycle Policy API to HLRC #33323
Conversation
Adds Request and Reponse classes for accessing lifecycle policies. Changes existing tests to use these classes where appropriate. Sets up SPI configuration to allow parsing *Actions from XContent.
gwbrown
added
the
:Data Management/ILM+SLM
|
Pinging @elastic/es-core-infra |
|
ill have a look today |
|
+1 to using SPI for the custom XContent. cc @talevy who was also asking me about this the other day. |
| } | ||
|
|
||
| @Override | ||
| public XContentBuilder toXContent(XContentBuilder builder, ToXContent.Params params) throws IOException { |
There was a problem hiding this comment.
Do you need this? I dont see it being used anywhere.
There was a problem hiding this comment.
It's used to leverage AbstractXContentTestCase for testing parsing in GetLifecyclePolicyResponseTests. If there's a better way of doing that, please let me know!
There was a problem hiding this comment.
I dont have a good answer for this yet. While we can totally test this, the value in the server -> client.fromXContent is greater than just testing the client.toXContent -> client.fromXContent. I think these kinds of tests are not really providing much value, and we also test the former in the IT tests.
|
@elasticmachine retest this please The failure is not related to anything this PR touches and does not reproduce locally. |
Adds Request and Reponse classes for accessing lifecycle policies. Changes existing tests to use these classes where appropriate. Sets up SPI configuration to allow parsing *Actions from XContent.
Adds Request and Reponse classes for accessing lifecycle policies.
Changes existing tests to use these classes where appropriate.
Sets up SPI configuration to allow parsing *Actions from XContent.
Relates to #33100