Logging: Further clean up logging ctors #33378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drops and unused logging constructor, simplifies a rarely used one, and removes `Settings` from a third. There is now only a single logging ctor that takes `Settings` and we'll remove that one in a follow up change.
nik9000
added
review
:Core/Infra/Logging
|
Pinging @elastic/es-core-infra |
nik9000
added a commit
that referenced
this pull request
Sep 5, 2018
Drops and unused logging constructor, simplifies a rarely used one, and removes `Settings` from a third. There is now only a single logging ctor that takes `Settings` and we'll remove that one in a follow up change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops and unused logging constructor, simplifies a rarely used one, and
removes
Settingsfrom a third. There is now only a single logging ctorthat takes
Settingsand we'll remove that one in a follow up change.