-
Notifications
You must be signed in to change notification settings - Fork 25.2k
HLRC: ML Update Job #33392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLRC: ML Update Job #33392
Conversation
Pinging @elastic/ml-core |
Pinging @elastic/es-core-infra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left a few minor comments.
@@ -356,6 +358,38 @@ public void flushJobAsync(FlushJobRequest request, RequestOptions options, Actio | |||
Collections.emptySet()); | |||
} | |||
|
|||
/** | |||
* Updates a Machine Learning {@link org.elasticsearch.client.ml.job.config.Job} properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we delete properties
?
*/ | ||
public class UpdateJobRequest extends ActionRequest implements ToXContentObject { | ||
|
||
private JobUpdate update; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make final
[[java-rest-high-x-pack-ml-update-job-request]] | ||
==== Update Job Request | ||
|
||
A `UpdateJobRequest` object gets created with an `JobUpdate` object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an
-> a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should just always make The
so there is a certain authority and exactness to it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds the ability to update a Machine Learning job through the HLRC.
This relates to (#29827)