add notion of version and creation_date to LifecyclePolicyMetadata #33450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
WIP
:Data Management/ILM+SLM
|
Pinging @elastic/es-core-infra |
talevy
force-pushed
the
ilm-version
branch
3 times, most recently
from
ce3a034 to
0b0bba4
Compare
It is useful to keep track of which version of a policy is currently being executed by a specific index. For management purposes, it would also be useful to know at which time the latest version was inserted so that an audit trail is left for reconciling changes happening in ILM.
colings86
requested changes
Sep 6, 2018
| @@ -37,42 +38,49 @@ public Response newResponse() { | |||
|
|
|||
| public static class Response extends ActionResponse implements ToXContentObject { | |||
|
|
|||
| private List<LifecyclePolicy> policies; | |||
| private Map<LifecyclePolicy, Tuple<Long, String>> policiesToMetadata; | |||
There was a problem hiding this comment.
I think we should make this nicer here. Having a map is not nice because the key is not something you are realistically going to to use to lookup things and Tuples are generally not particularly nice to consume. Can we create a wrapper class around the policy, date and version so we have an object that is easier to consume both for us internally and for users of the transport API (given this class will be exposed to the Transport API)?
|
thanks @colings86, I've updated to use a proper class |
colings86
reviewed
Sep 6, 2018
| for (LifecyclePolicyMetadata policyMetadata : requestedPolicies) { | ||
| responseItems.add(new LifecyclePolicyResponseItem(policyMetadata.getPolicy(), | ||
| policyMetadata.getVersion(), policyMetadata.getCreationDateString())); | ||
| } |
There was a problem hiding this comment.
Can we not create the list of LifecyclePolicyResponseItem directly rather than first creating the list of LifecyclePolicyMetadata?
colings86
approved these changes
Sep 6, 2018
talevy
added a commit
that referenced
this pull request
Sep 6, 2018
…33450) It is useful to keep track of which version of a policy is currently being executed by a specific index. For management purposes, it would also be useful to know at which time the latest version was inserted so that an audit trail is left for reconciling changes happening in ILM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to keep track of which version of a policy is currently
being executed by a specific index. For management purposes, it would
also be useful to know at which time the latest version was inserted
so that an audit trail is left for reconciling changes happening in ILM.
The work here only adds a notion of version and creation_date to the lifecycle-metadata. The index settings are not updated with which version their currently executed
phase_definitionis because these settings are to be moved to custom indexmetadata anyways, and I would prefer to minimize conflicts here, happy to do this in a follow-up if the time is right.