move ILM client objects from protocol to client #33532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra |
gwbrown
approved these changes
Sep 7, 2018
There was a problem hiding this comment.
This works for resolving your immediate problem, although long-term we want to switch to having the Request objects implement Validatable rather than extend ActionRequest (or subclasses thereof). That said, this is a good first step and those hierarchy changes can be done later if you're in a hurry.
If you want to make those changes in this PR though, that would be great.
|
thanks @gwbrown. cleaning up the hierarchy can be done at a later time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pretty straightforward migration (assuming this is correct)