[HLRC][ML] Add ML put datafeed API to HLRC #33603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitris-athanasiou
added
>enhancement
review
v7.0.0
:ml
|
Pinging @elastic/es-core-infra |
|
Pinging @elastic/ml-core |
dimitris-athanasiou
force-pushed
the
add-ml-put-datafeed-to-hlrc
branch
from
422384e to
2e46279
Compare
98 tasks
droberts195
approved these changes
Sep 12, 2018
| * For additional info | ||
| * see <a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/ml-put-datafeed.html">ML PUT datafeed documentation</a> | ||
| * | ||
| * @param request The PutDatafeedRequest containing the {@link org.elasticsearch.client.ml.datafeed.DatafeedConfig} settings |
There was a problem hiding this comment.
The indenting is out here
| && Objects.equals(this.scrollSize, that.scrollSize) | ||
| && Objects.equals(this.aggregations, that.aggregations) | ||
| && Objects.equals(asMap(this.aggregations), asMap(that.aggregations)) |
There was a problem hiding this comment.
Using asMap() in equals() and hashCode() will make them heavyweight operations. Maybe that's OK if these methods are only really used in the serialization test. But it might be worth adding a comment to point out the potential inefficiency.
There was a problem hiding this comment.
I copied this pattern from PipelineConfiguration where config is also stored as BytesReference. It is necessary as otherwise equality/hash don't work correctly. I'll add a comment.
| && Objects.equals(this.scrollSize, that.scrollSize) | ||
| && Objects.equals(this.aggregations, that.aggregations) | ||
| && Objects.equals(asMap(this.aggregations), asMap(that.aggregations)) |
There was a problem hiding this comment.
As above regarding complex operations in equals() and hashCode()
This also changes both `DatafeedConfig` and `DatafeedUpdate` to store the query and aggs as a bytes reference. This allows the client to remove its dependency to the named objects registry of the search module. Relates elastic#29827
dimitris-athanasiou
force-pushed
the
add-ml-put-datafeed-to-hlrc
branch
from
2a2ab7c to
cd49302
Compare
dimitris-athanasiou
added a commit
that referenced
this pull request
Sep 12, 2018
This also changes both `DatafeedConfig` and `DatafeedUpdate` to store the query and aggs as a bytes reference. This allows the client to remove its dependency to the named objects registry of the search module. Relates #29827
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 12, 2018
* master: [HLRC][ML] Add ML put datafeed API to HLRC (elastic#33603) Update AWS SDK to 1.11.406 in repository-s3 (elastic#30723)
jasontedor
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Sep 12, 2018
* master: (43 commits) [HLRC][ML] Add ML put datafeed API to HLRC (elastic#33603) Update AWS SDK to 1.11.406 in repository-s3 (elastic#30723) Expose CCR stats to monitoring (elastic#33617) [Docs] Update match-query.asciidoc (elastic#33610) TEST: Adjust rollback condition when shard is empty [CCR] Improve shard follow task's retryable error handling (elastic#33371) Forbid negative `weight` in Function Score Query (elastic#33390) Clarify context suggestions filtering and boosting (elastic#33601) Disable CCR REST endpoints if CCR disabled (elastic#33619) Lower version on full cluster restart settings test Upgrade remote cluster settings (elastic#33537) NETWORKING: http.publish_host Should Contain CNAME (elastic#32806) Add test coverage for global checkpoint listeners Reset replica engine to global checkpoint on promotion (elastic#33473) HLRC: ML Delete Forecast API (elastic#33526) Remove debug logging in full cluster restart tests (elastic#33612) Expose CCR to the transport client (elastic#33608) Mute testIndexDeletionWhenNodeRejoins SQL: Make Literal a NamedExpression (elastic#33583) [DOCS] Adds missing built-in user information (elastic#33585) ...
jasontedor
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Sep 12, 2018
* master: (128 commits) [HLRC][ML] Add ML put datafeed API to HLRC (elastic#33603) Update AWS SDK to 1.11.406 in repository-s3 (elastic#30723) Expose CCR stats to monitoring (elastic#33617) [Docs] Update match-query.asciidoc (elastic#33610) TEST: Adjust rollback condition when shard is empty [CCR] Improve shard follow task's retryable error handling (elastic#33371) Forbid negative `weight` in Function Score Query (elastic#33390) Clarify context suggestions filtering and boosting (elastic#33601) Disable CCR REST endpoints if CCR disabled (elastic#33619) Lower version on full cluster restart settings test Upgrade remote cluster settings (elastic#33537) NETWORKING: http.publish_host Should Contain CNAME (elastic#32806) Add test coverage for global checkpoint listeners Reset replica engine to global checkpoint on promotion (elastic#33473) HLRC: ML Delete Forecast API (elastic#33526) Remove debug logging in full cluster restart tests (elastic#33612) Expose CCR to the transport client (elastic#33608) Mute testIndexDeletionWhenNodeRejoins SQL: Make Literal a NamedExpression (elastic#33583) [DOCS] Adds missing built-in user information (elastic#33585) ...
jasontedor
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Sep 12, 2018
* master: Fix checkstyle violation in ShardFollowNodeTask [HLRC][ML] Add ML put datafeed API to HLRC (elastic#33603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes both
DatafeedConfigandDatafeedUpdateto store the query and aggs as a bytes reference. This allows
the client to remove its dependency to the named objects
registry of the search module.
Relates #29827