Skip to content

Docs: Add a note about rollover issues #33679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2018

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Sep 13, 2018

6.4 has a bad bug where it won't if any of the shards on the node have
been rolled over. This documents that in the known issues for 6.4.0 and
links to the fix in the bug fixes section of 6.4.1.

Relates to #33394

6.4 has a bad bug where it won't if any of the shards on the node have
been rolled over. This documents that in the known issues for 6.4.0 and
links to the fix in the bug fixes section of 6.4.1.

Relates to elastic#33394
@nik9000 nik9000 added >docs General docs changes v6.4.1 labels Sep 13, 2018
@nik9000 nik9000 requested a review from lcawl September 13, 2018 17:01
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. I think we should put this on the 6.4.0 blog too.


Rollover::
{es} can once again start if any shards on the node have been
<<indices-rollover-index, rolled over>>. {pull}33394[#33394]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to wait to be added until 6.4.1 release time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're already generated 6.4.1 release notes with a "coming in 6.4.1" note. I think it is ok to add this to that page.

@@ -70,6 +74,11 @@ coming[6.4.1]
[float]
=== Known issues

Rollover::
{es} can't start if any of the shards on the node have been
<<indices-rollover-index, rolled over>>. (issue: {issue}33316[#33316])
Copy link
Member

@jasontedor jasontedor Sep 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we need to highlight this more loudly (and the existing known issue for 6.4.0). Please see #32135 for how I think this should be done.

@@ -170,15 +177,15 @@ Java High Level REST Client::
* Rest High Level client: Add List Tasks {pull}29546[#29546] (issue: {issue}27205[#27205])

Machine learning::
* Detectors now support {stack-ov}/ml-rules.html[custom rules] that enable the
user to improve machine learning results by providing some domain-specific
* Detectors now support {stack-ov}/ml-rules.html[custom rules] that enable the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you avoid the formatting changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@nik9000
Copy link
Member Author

nik9000 commented Sep 13, 2018

@jasontedor I've pushed an update. Could you have another look?

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried building it, but it LGTM

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nik9000 nik9000 merged commit 3f9fe6e into elastic:6.4 Sep 13, 2018
@nik9000
Copy link
Member Author

nik9000 commented Sep 13, 2018

Thanks for all of your suggestions @jasontedor and @lcawl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes v6.4.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants