Skip to content

HLRC: Get ML calendars #33760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2018
Merged

HLRC: Get ML calendars #33760

merged 1 commit into from
Sep 18, 2018

Conversation

davidkyle
Copy link
Member

For #29827

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just left one opinion on the docs.

==== Get Calendars Request

By default a `GetCalendarsRequest` with no calendar Id set will return all
calendars, using the literal `_all` also returns all calendars.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might sound better with a full stop rather than a comma after "calendars". Then "Using the literal _all..." as a new sentence.

@davidkyle davidkyle merged commit 9543992 into elastic:master Sep 18, 2018
@davidkyle davidkyle deleted the hlrc-get-cal branch September 18, 2018 10:51
davidkyle added a commit that referenced this pull request Sep 18, 2018
@benwtrent benwtrent removed the :ml Machine learning label Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants