Skip to content

Ingest Attachement: Upgrade tika to v1.19.1 #33896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 12, 2018

Conversation

jkakavas
Copy link
Member

@jkakavas jkakavas commented Sep 20, 2018

Upgrades Apache Tika to v1.19.

Also upgrades transitive dependencies:

pdfbox : 2.0.9 -> 2.0.12
poi : 3.17 -> 4.0.0'
commons-compress:1.16.1 -> 1.18

@jkakavas jkakavas added >non-issue :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v7.0.0 v6.5.0 v6.4.2 labels Sep 20, 2018
@jkakavas jkakavas requested a review from jasontedor September 20, 2018 12:11
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@jkakavas jkakavas changed the title Ingest Attachement: Upgrade tika to v1.19 [WIP] Ingest Attachement: Upgrade tika to v1.19 Sep 21, 2018
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment, capturing our discussion from another thread.

@@ -33,4 +33,6 @@ grant {
permission java.lang.RuntimePermission "accessDeclaredMembers";
// PDFBox checks for the existence of this class
permission java.lang.RuntimePermission "accessClassInPackage.sun.java2d.cmm.kcms";
// TODO: Remove once https://issues.apache.org/jira/browse/TIKA-2731 is resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed via another thread, let’s hold here until 1.19.1 is released so that we do not need to make this grant.

@jaymode
Copy link
Member

jaymode commented Sep 28, 2018

I'm not sure if you want to add un-muting tests that failed on JDK11 to this PR as they were waiting on this upgrade; if you do the issues are #31456 and #31305.

@jkakavas
Copy link
Member Author

jkakavas commented Oct 1, 2018

Thanks for bringing this to my attention @jaymode . I will make sure the issues are resolved with 1.19.1 and unmute them in this PR as part of the upgrade

@jkakavas jkakavas changed the title [WIP] Ingest Attachement: Upgrade tika to v1.19 [WIP] Ingest Attachement: Upgrade tika to v1.19.1 Oct 10, 2018
@jkakavas jkakavas added v6.4.3 and removed v6.4.2 labels Oct 10, 2018
@jkakavas
Copy link
Member Author

The CI failure was a transient issue:

 > Could not resolve org.hamcrest:hamcrest-core:1.3.
10:14:46   [bwc]       > Could not get resource 'https://jcenter.bintray.com/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.pom'.
10:14:46   [bwc]          > Could not HEAD 'https://jcenter.bintray.com/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.pom'. Received status code 502 from server: Bad Gateway

I unmuted previously failing tests from #31456 and #31305 since we needed the extra CI run eitherway

@jkakavas jkakavas merged commit 080ddd5 into elastic:master Oct 12, 2018
jkakavas added a commit that referenced this pull request Oct 12, 2018
Upgrades Tika to 1.19.1 and relevant transitive dependencies

Resolves: #31456, #31305
jkakavas added a commit that referenced this pull request Oct 12, 2018
Upgrades Tika to 1.19.1 and relevant transitive dependencies

Resolves: #31456, #31305
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Oct 15, 2018
* elastic/master:
  Mute PartitionedRoutingIT#testShrinking on Windows
  Mute testToQuery test
  [TEST] Make sure there are shards started so that `ESIntegTestCase#assertSameDocIdsOnShards()` does not fail with shard not found.
  Change shard changes api's threadpool from get to search (elastic#34421)
  Update TESTING.asciidoc title (elastic#34401)
  Tests: Fix DateFormatter equals tests with locale (elastic#34435)
  Docs: Remove unnecessary qualifier from wildcard import note (elastic#34419)
  CCR/TEST: AwaitsFix testFailOverOnFollower
  [Painless] Add a Map for java names to classes for use in the custom classloader (elastic#34424)
  TEST: Fix indentation in FullClusterRestartIT (elastic#34420)
  [WIP] Ingest Attachement: Upgrade tika to v1.19.1 (elastic#33896)
  NETWORKING: Upgrade Netty to 4.1.30 (elastic#34417)
  Allow an AuthenticationResult to return metadata (elastic#34382)
  [ML] Add an ingest pipeline definition to structure finder (elastic#34350)
  Handle pre-6.x time fields (elastic#34373)
  ListenableFuture should preserve ThreadContext (elastic#34394)
@jkakavas jkakavas changed the title [WIP] Ingest Attachement: Upgrade tika to v1.19.1 Ingest Attachement: Upgrade tika to v1.19.1 Oct 15, 2018
@jkakavas jkakavas deleted the upgrade-tika branch October 15, 2018 15:48
kcm pushed a commit that referenced this pull request Oct 30, 2018
Upgrades Tika to 1.19.1 and relevant transitive dependencies

Resolves: #31456, #31305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >non-issue v6.4.3 v6.5.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants