Skip to content

SQL: Move away internally from JDBCType to SQLType #33913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2018
Merged

SQL: Move away internally from JDBCType to SQLType #33913

merged 1 commit into from
Sep 22, 2018

Conversation

costin
Copy link
Member

@costin costin commented Sep 20, 2018 •
edited
Loading

This is a first step in allowing our own custom types (such as Interval) internally and within JDBC as we're moving away from a fixed enum to a pluggable interface (which is implemented by JDBCType as well).

Fix #33904

@costin costin requested review from astefan and matriv September 20, 2018 18:04
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

astefan
astefan approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

matriv
matriv approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin costin merged commit 17605bf into elastic:master Sep 22, 2018
costin added a commit that referenced this pull request Sep 22, 2018
@costin
SQL: Move away internally from JDBCType to SQLType (#33913)
6bb42c6 
Replace JDBCType enum with SQLType interface for extensibility

Fix #33094

(cherry picked from commit 17605bf)
@costin costin deleted the fix-33094 branch September 22, 2018 08:18
@costin costin mentioned this pull request Sep 24, 2018
Closed
kcm pushed a commit that referenced this pull request Oct 30, 2018
@costin @kcm
SQL: Move away internally from JDBCType to SQLType (#33913)
3351da5 
Replace JDBCType enum with SQLType interface for extensibility

Fix #33094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefan astefan astefan approved these changes

@matriv matriv matriv approved these changes

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >enhancement v6.5.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL: Move away from JDBCType to SQLType
5 participants
@costin @elasticmachine @astefan @matriv @colings86