HLRC: Add throttling for update & delete-by-query #33951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds throttling to the update-by-query and delete-by-query cases similar to throttling for reindex. This mostly means additional methods on the client class itself, since the request hits the same RestHandler, just with slightly different endpoints, and also the return values are similar. Also updating the docs to reflect this.
|
Pinging @elastic/es-core-infra |
cbuescher
commented
Sep 21, 2018
rest-api-spec/src/main/resources/rest-api-spec/api/delete_by_query_rethrottle.json
Show resolved
Hide resolved
|
@nik9000 thanks, I addressed your comment |
nik9000
approved these changes
Oct 2, 2018
| @@ -855,6 +900,8 @@ public void testDeleteByQuery() throws IOException { | |||
| .source(Collections.singletonMap("foo", 1), XContentType.JSON)) | |||
| .add(new IndexRequest(sourceIndex, "type", "2") | |||
| .source(Collections.singletonMap("foo", 2), XContentType.JSON)) | |||
| .add(new IndexRequest(sourceIndex, "type", "3") | |||
| .source(Collections.singletonMap("foo", 3), XContentType.JSON)) | |||
There was a problem hiding this comment.
You indent this differently than the thing above it.
There was a problem hiding this comment.
Non-intentional indenting indeed. As penance I now will have to repeat this rapidly a couple of times. And will change of course.
|
@nik9000 thanks for the review. I think I will not wait for another full CI run just because of the last re-indention commit but merge to master regardless. |
cbuescher
pushed a commit
that referenced
this pull request
Oct 2, 2018
This change adds throttling to the update-by-query and delete-by-query cases similar to throttling for reindex. This mostly means additional methods on the client class itself, since the request hits the same RestHandler, just with slightly different endpoints, and also the return values are similar.
80 tasks
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
This change adds throttling to the update-by-query and delete-by-query cases similar to throttling for reindex. This mostly means additional methods on the client class itself, since the request hits the same RestHandler, just with slightly different endpoints, and also the return values are similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds throttling to the update-by-query and delete-by-query cases
similar to throttling for reindex. This mostly means additional methods on the
client class itself, since the request hits the same RestHandler, just with
slightly different endpoints, and also the return values are similar.
Also updating the docs to reflect this.