Skip to content

Test: Revert pinning MockWebServer to TLSv1.2 #34148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

jaymode
Copy link
Member

@jaymode jaymode commented Sep 28, 2018

Revert "[TESTS] Pin MockWebServer to TLS1.2 (#33127)" (commit
214652d) and "Pin TLS1.2 in
SSLConfigurationReloaderTests" (commit
d9f5e4f), which pinned the
MockWebServer used in the SSLConfigurationReloaderTests to TLSv1.2 in
order to prevent failures with JDK 11 related to ssl session
invalidation. We no longer need this pinning as the problematic code
was fixed in #34130.

Revert "[TESTS] Pin MockWebServer to TLS1.2 (elastic#33127)" (commit
214652d) and "Pin TLS1.2 in
SSLConfigurationReloaderTests" (commit
d9f5e4f), which pinned the
MockWebServer used in the SSLConfigurationReloaderTests to TLSv1.2 in
order to prevent failures with JDK 11 related to ssl session
invalidation. We no longer need this pinning as the problematic code
was fixed in elastic#34130.
@jaymode jaymode added >test Issues or PRs that are addressing/adding tests v7.0.0 :Security/TLS SSL/TLS, Certificates v6.5.0 labels Sep 28, 2018
@jaymode jaymode requested a review from jkakavas September 28, 2018 15:12
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaymode jaymode merged commit 8539fb6 into elastic:master Oct 2, 2018
@jaymode jaymode deleted the revert_tls12_pin branch October 2, 2018 15:54
jaymode added a commit that referenced this pull request Oct 2, 2018
@jaymode jaymode removed the v6.5.0 label Oct 2, 2018
kcm pushed a commit that referenced this pull request Oct 30, 2018
Revert "[TESTS] Pin MockWebServer to TLS1.2 (#33127)" (commit
214652d) and "Pin TLS1.2 in
SSLConfigurationReloaderTests" (commit
d9f5e4f), which pinned the
MockWebServer used in the SSLConfigurationReloaderTests to TLSv1.2 in
order to prevent failures with JDK 11 related to ssl session
invalidation. We no longer need this pinning as the problematic code
was fixed in #34130.
kcm pushed a commit that referenced this pull request Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Security/TLS SSL/TLS, Certificates >test Issues or PRs that are addressing/adding tests v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants