Skip to content

Docs: Fix typo in field name in aggregations #34223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Docs: Fix typo in field name in aggregations #34223

merged 1 commit into from
Oct 2, 2018

Conversation

populov
Copy link
Contributor

@populov populov commented Oct 2, 2018

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

@nik9000 nik9000 self-assigned this Oct 2, 2018
@nik9000 nik9000 added >docs General docs changes :Analytics/Aggregations Aggregations labels Oct 2, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@nik9000
Copy link
Member

nik9000 commented Oct 2, 2018

Thanks for this @populov! I'll make sure everything is good and merge soon.

@nik9000 nik9000 changed the title Fix typo in sample field name Docs: Fix typo in field name in aggregations doc Oct 2, 2018
@nik9000 nik9000 changed the title Docs: Fix typo in field name in aggregations doc Docs: Fix typo in field name in aggregations Oct 2, 2018
@nik9000
Copy link
Member

nik9000 commented Oct 2, 2018

It looks like the way this is written the aggregation returns empty with the wrong name. That seems like a strange thing, but it explain why the docs testing infrastructure didn't catch this. I'll merge and forward port to master and 6.x

@nik9000
Copy link
Member

nik9000 commented Oct 2, 2018

And 6.4.

@nik9000
Copy link
Member

nik9000 commented Oct 2, 2018

I've merged and forward ported to 6.4, 6.5, and master. Thanks again @populov!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants