Introduce durability of circuit breaking exception #34460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we differentiate between permanent circuit breaking exceptions (which require intervention from an operator and should not be automatically retried) and transient ones (which may heal themselves eventually and should be retried). Furthermore, the parent circuit breaker will categorize a circuit breaking exception as either transient or permanent based on the categorization of memory usage of its child circuit breakers. Closes elastic#31986
danielmitterdorfer
added
>enhancement
:Core/Infra/Circuit Breakers
|
Pinging @elastic/es-core-infra |
|
cc @elastic/es-clients |
With this commit we fix a test failure due to an unregistered exception that we have created for test purposes only. Instead we use now an already registered class that has the desired properties (only has numeric fields and overrides `#metadataToXContent()`.
dakrone
approved these changes
Oct 22, 2018
| CircuitBreakingException ex = serialize(new CircuitBreakingException("I hate to say I told you so...", 0, 100)); | ||
| assertEquals("I hate to say I told you so...", ex.getMessage()); | ||
| CircuitBreakingException ex = serialize(new CircuitBreakingException("Too large", 0, 100, CircuitBreaker.Durability.TRANSIENT), | ||
| randomFrom(Version.V_7_0_0_alpha1)); |
There was a problem hiding this comment.
I don't think we need the randomFrom for a single version here? Especially since this isn't planned for backporting this can be Version.CURRENT right?
There was a problem hiding this comment.
Thanks. I've removed the randomization now.
|
Thanks for your review @dakrone. I've also marked it as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we differentiate between permanent circuit breaking exceptions
(which require intervention from an operator and should not be automatically
retried) and transient ones (which may heal themselves eventually and should be
retried). Furthermore, the parent circuit breaker will categorize a circuit
breaking exception as either transient or permanent based on the categorization
of memory usage of its child circuit breakers.
In order to make handling in our client library more consistent with existing
helpers and also help differentiate it from other errors which lead to a node
(temporarily) being removed from the list of nodes to connect to, we will not
use HTTP status code 503 anymore but rather 429.
Closes #31986