HLRC XPack Protocol clean up: Licence, Misc #34469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra |
7 tasks
| } | ||
|
|
||
| public void testPutLicense() throws Exception { | ||
| // TODO |
hub-cap
suggested changes
Oct 16, 2018
|
|
||
| public class XPackUsageRequest extends MasterNodeRequest<XPackUsageRequest> { |
There was a problem hiding this comment.
lolwut... thanks for nothing, git.
| @@ -58,7 +55,7 @@ | |||
| }); | |||
|
|
|||
| static { | |||
| PARSER.declareBoolean(constructorArg(), new ParseField("acknowledged")); | |||
There was a problem hiding this comment.
i actually dont mind having these defined here if we dont use them anywhere else.
added 8 commits
October 16, 2018 16:40
|
run gradle build tests please |
hub-cap
approved these changes
Oct 19, 2018
|
thanks @hub-cap for the review |
vladimirdolzhenko
added a commit
that referenced
this pull request
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move parts related to XPack Licence and Misc from protocol to client
Relates #34451