LLREST: Wrap at 140 columns #34489
Merged
LLREST: Wrap at 140 columns #34489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wraps a single line in a test to fit on 140 characters, removing the only checkstyle suppression for the clients directory.
nik9000
added
:Clients/Java Low Level REST Client
|
Pinging @elastic/es-core-infra |
jasontedor
reviewed
Oct 15, 2018
| @@ -106,7 +106,8 @@ public void testCanConfigureHeapBufferLimitFromOutsidePackage() throws ClassNotF | |||
| IllegalAccessException, InvocationTargetException, InstantiationException { | |||
| int bufferLimit = randomIntBetween(1, Integer.MAX_VALUE); | |||
| //we use reflection to make sure that the class can be instantiated from the outside, and the constructor is public | |||
| Constructor<?> constructor = HttpAsyncResponseConsumerFactory.HeapBufferedResponseConsumerFactory.class.getConstructor(Integer.TYPE); | |||
| Constructor<?> constructor = HttpAsyncResponseConsumerFactory.HeapBufferedResponseConsumerFactory.class | |||
| .getConstructor(Integer.TYPE); | |||
There was a problem hiding this comment.
Does it fit if you wrap after the equals?
|
@elasticmachine, retest this please |
nik9000
added a commit
that referenced
this pull request
Oct 17, 2018
Wraps a single line in a test to fit on 140 characters, removing the only checkstyle suppression for the clients directory.
|
Thanks for reviewing @jasontedor! |
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Wraps a single line in a test to fit on 140 characters, removing the only checkstyle suppression for the clients directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps a single line in a test to fit on 140 characters, removing the
only checkstyle suppression for the clients directory.