Build: Drop missing checkstyle suppressions #34490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops checkstyle suppressions that refer to files that don't exist since those suppressions don't do anything other than make us feel bad. It also updates some suppressions to more closely match the path to the file that they suppress. These suppressions are still needed but didn't pass the "the file exists" test because they weren't precise. It is just easier on future-me if they are precise.
|
Pinging @elastic/es-core-infra |
nik9000
added a commit
that referenced
this pull request
Oct 16, 2018
This drops checkstyle suppressions that refer to files that don't exist since those suppressions don't do anything other than make us feel bad. It also updates some suppressions to more closely match the path to the file that they suppress. These suppressions are still needed but didn't pass the "the file exists" test because they weren't precise. It is just easier on future-me if they are precise.
|
Thanks for reviewing @jasontedor! I've merged to master and backported. |
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
This drops checkstyle suppressions that refer to files that don't exist since those suppressions don't do anything other than make us feel bad. It also updates some suppressions to more closely match the path to the file that they suppress. These suppressions are still needed but didn't pass the "the file exists" test because they weren't precise. It is just easier on future-me if they are precise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops checkstyle suppressions that refer to files that don't exist
since those suppressions don't do anything other than make us feel bad.
It also updates some suppressions to more closely match the path to the
file that they suppress. These suppressions are still needed but didn't
pass the "the file exists" test because they weren't precise. It is just
easier on future-me if they are precise.