[CCR] Fix request serialization bug #34917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and some parameters that were not set in tests.
martijnvg
added
>non-issue
:Distributed Indexing/CCR
|
Pinging @elastic/es-distributed |
martijnvg
commented
Oct 26, 2018
| @@ -137,9 +137,6 @@ public void testAutoFollowParameterAreDelegated() throws Exception { | |||
| if (randomBoolean()) { | |||
| request.setMaxReadRequestOperationCount(randomIntBetween(0, Integer.MAX_VALUE)); | |||
| } | |||
| if (randomBoolean()) { | |||
There was a problem hiding this comment.
removed, because is a duplicate if statement
dnhatn
approved these changes
Oct 26, 2018
| @@ -266,6 +266,8 @@ public void readFrom(final StreamInput in) throws IOException { | |||
| maxReadRequestOperationCount = in.readOptionalVInt(); | |||
| maxOutstandingReadRequests = in.readOptionalVInt(); | |||
| maxReadRequestSize = in.readOptionalWriteable(ByteSizeValue::new); | |||
There was a problem hiding this comment.
Would you mind moving maxReadRequestSize above maxOutstandingReadRequests so that we have the same order for both read and write.
martijnvg
added a commit
that referenced
this pull request
Oct 29, 2018
and some parameters that were not set in tests.
martijnvg
added a commit
that referenced
this pull request
Oct 29, 2018
and some parameters that were not set in tests.
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
and some parameters that were not set in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and some parameters that were not set in tests.