Skip to content

Docs: HLRC: refactor bulk, migrate and reindex apis #35413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 16, 2018

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Nov 9, 2018

fix typos and refactor to DRY up documentation for bulk, reindex and migration apis
relates #35345

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@pgomulka
Copy link
Contributor Author

pgomulka commented Nov 9, 2018

this is work in progress, will add more from the migration API once commited

@pgomulka pgomulka force-pushed the docs/improve-migration-bulk-index branch from 62254bb to ead37a0 Compare November 14, 2018 13:28
@pgomulka pgomulka force-pushed the docs/improve-migration-bulk-index branch from ead37a0 to ae42d3e Compare November 14, 2018 13:33
@pgomulka pgomulka requested a review from nik9000 November 14, 2018 13:34
@pgomulka pgomulka self-assigned this Nov 14, 2018
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think it is an improvement.

for more information on how to build `DeleteRequest`.
<2> Adds an `UpdateRequest` to the `BulkRequest`. See <<{upid}-update>>
<2> Adds an `UpdateRequest` to the +{request}+. See <<{upid}-update>>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@pgomulka pgomulka merged commit c6e2634 into elastic:master Nov 16, 2018
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Nov 16, 2018
fix typos and refactor to DRY up documentation for bulk, reindex and migration apis
relates elastic#35345
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Nov 19, 2018
fix typos and refactor to DRY up documentation for bulk, reindex and migration apis
relates elastic#35345
pgomulka added a commit that referenced this pull request Nov 19, 2018
fix typos and refactor to DRY up documentation for bulk, reindex and migration apis
relates #35345 
backport of #35413
@jakelandis
Copy link
Contributor

@pgomulka - It looks like this was back ported on 7df652a ? If so, can you please remove the backport pending label.

@pgomulka
Copy link
Contributor Author

pgomulka commented Feb 1, 2019

sure - i totally missed that. thank you for spotting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants