Zen2: Add basic Zen1 transport-level BWC #35443
Conversation
ywelsch
added
>enhancement
v7.0.0
:Distributed Coordination/Cluster Coordination
|
Pinging @elastic/es-distributed |
| } | ||
| } | ||
|
|
||
| public static Settings.Builder addZen1Attribute(Settings.Builder builder) { |
There was a problem hiding this comment.
Perhaps insert:
// only here temporarily for BWC development, TODO remove once complete
Assuming we are going to remove this before GA?
| } | ||
|
|
||
| public static boolean isZen1Node(DiscoveryNode discoveryNode) { | ||
| return discoveryNode.getVersion().before(Version.V_7_0_0) || discoveryNode.getAttributes().containsKey("zen1"); |
There was a problem hiding this comment.
Similarly, if the zen1 attribute is going to go away then we should note this here.
| @@ -103,8 +108,12 @@ public FollowersChecker(Settings settings, TransportService transportService, | |||
| followerCheckRetryCount = FOLLOWER_CHECK_RETRY_COUNT_SETTING.get(settings); | |||
|
|
|||
| updateFastResponseState(0, Mode.CANDIDATE); | |||
| transportService.registerRequestHandler(FOLLOWER_CHECK_ACTION_NAME, Names.SAME, FollowerCheckRequest::new, | |||
| transportService.registerRequestHandler(FOLLOWER_CHECK_ACTION_NAME, Names.SAME, false, false, FollowerCheckRequest::new, | |||
There was a problem hiding this comment.
As far as I can tell this change is to set canTripCircuitBreaker to false. Do we definitely want to count a follower as healthy if a ping would trip its circuit breaker?
There was a problem hiding this comment.
That's a good question. I wonder if it's something we should discuss with a larger group, but go with Zen1 defaults for now.
| if (Coordinator.isZen1Node(discoveryNode)) { | ||
| actionName = NodesFaultDetection.PING_ACTION_NAME; | ||
| transportRequest = new NodesFaultDetection.PingRequest(discoveryNode, ClusterName.CLUSTER_NAME_SETTING.get(settings), | ||
| transportService.getLocalNode(), 0L); |
There was a problem hiding this comment.
Maybe ClusterState.UNKNOWN_VERSION instead of 0L?
| if (Coordinator.isZen1Node(discoveryNode)) { | ||
| actionName = UnicastZenPing.ACTION_NAME; | ||
| transportRequest = new UnicastZenPing.UnicastPingRequest(1, ZenDiscovery.PING_TIMEOUT_SETTING.get(settings), | ||
| new ZenPing.PingResponse(getLocalNode(), null, ClusterName.CLUSTER_NAME_SETTING.get(settings), 0L)); |
There was a problem hiding this comment.
Maybe ClusterState.UNKNOWN_VERSION instead of 0L?
| final List<ZenPing.PingResponse> pingResponses = new ArrayList<>(); | ||
| final ClusterName clusterName = ClusterName.CLUSTER_NAME_SETTING.get(settings); | ||
| pingResponses.add(new ZenPing.PingResponse(transportService.getLocalNode(), peersResponse.getMasterNode().orElse(null), | ||
| clusterName, 0L)); |
There was a problem hiding this comment.
Maybe ClusterState.UNKNOWN_VERSION instead of 0L?
Implements serialization compatibility between Zen1 and Zen2 transport action, allowing a Zen1 node join a Zen2 master and vice-versa.