Skip to content

[ILM] Avoid NullPointerException in CopyExecutionStateStep #35568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Nov 14, 2018

In the event that the target index does not exist when CopyExecutionStateStep
executes, this avoids a NullPointerException and provides a more helpful error
to the ILM user.

Resolves #35567

In the event that the target index does not exist when `CopyExecutionStateStep`
executes, this avoids a `NullPointerException` and provides a more helpful error
to the ILM user.

Resolves elastic#35567
@dakrone dakrone added the :Data Management/ILM+SLM Index and Snapshot lifecycle management label Nov 14, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@@ -22,7 +22,7 @@
* new index has been created. Useful for actions such as shrink.
*/
public class CopyExecutionStateStep extends ClusterStateActionStep {
public static final String NAME = "copy_execution_state";
public static final String NAME = "copy-execution-state";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our other steps use kabob case, so this change is just to make it consistent with our other multi-word step names

Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dakrone dakrone merged commit 90b38d9 into elastic:master Nov 15, 2018
dakrone added a commit that referenced this pull request Nov 15, 2018
In the event that the target index does not exist when `CopyExecutionStateStep`
executes, this avoids a `NullPointerException` and provides a more helpful error
to the ILM user.

Resolves #35567
@dakrone dakrone deleted the ilm-avoid-npe-copy-execution-state branch November 15, 2018 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >non-issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants