ML: changing automatic check_window calculation #35643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
|
Didn't check if docs mention anything about how we calculate the default. If they do we need to update that too. |
|
@dimitris-athanasiou the docs just mention that we calculate a default, not how it is calculated. |
|
Be good for the docs to mention how it is calculated. It's a useful detail. |
|
@sophiec20 we don't really do that for our other default calculations. Though I can write something up if it is necessary. |
We probably should. |
benwtrent
added a commit
that referenced
this pull request
Nov 19, 2018
* ML: changing automatic check_window calculation * adding docs on how we calculate the default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unused ML message and changes how the default check_window is calculated.
Relates to: #35131