-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Fix "size" field in the body of AbstractBulkByScrollRequest #35742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The "size" field in the body of AbstractBulkByScrollRequest(DeleteByQuery/UpdateByQuery) is not taken into consideration anymore during some previous changes, this is to fix it.
Pinging @elastic/es-distributed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is almost right, but it has an issue for transport client users. I think. The trouble is that we didn't have any real testing of the default transport client behavior. But I'm fairly sure we should keep that default size setting. And that means changing Abstract rest controlled slightly. But I think this is on the right track!
@@ -130,7 +130,6 @@ public AbstractBulkByScrollRequest(SearchRequest searchRequest, boolean setDefau | |||
if (setDefaults) { | |||
searchRequest.scroll(DEFAULT_SCROLL_TIMEOUT); | |||
searchRequest.source(new SearchSourceBuilder()); | |||
searchRequest.source().size(DEFAULT_SCROLL_SIZE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should stay as it was or else transport client users will start to get a default scroll size of 10
again which won't perform well..
Hi @nik9000 I changed search XContent body parsing part and passed a setSize consumer inside to be able to "consume" |
The "size" field in the body of
AbstractBulkByScrollRequest(DeleteByQuery/UpdateByQuery)
is not taken into consideration anymore during some previous changes, and currently only passing "size" as parameter works forDeleteByQuery
orUpdateByQuery
. This is to fix it and make it worked again.Close #35636