[CCR] Only auto follow indices when all primary shards have started #35814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds an extra check that verifies that all primary shards have been started of an index that is about to be auto followed. If not all primary shards have been started for an index then the next auto follow run will try to follow to auto follow this index again. Closes elastic#35480
martijnvg
added
>bug
v7.0.0
:Distributed Indexing/CCR
|
Pinging @elastic/es-distributed |
jasontedor
reviewed
Nov 29, 2018
| if (followedIndexUUIDs.contains(leaderIndexMetaData.getIndex().getUUID()) == false) { | ||
| IndexRoutingTable indexRoutingTable = leaderClusterState.routingTable().index(leaderIndexMetaData.getIndex()); | ||
| if (indexRoutingTable != null && | ||
| indexRoutingTable.allPrimaryShardsActive() && |
There was a problem hiding this comment.
Looks good. Can you leave a comment explaining this though?
|
I will wait with backporting to the 6.5 branch, when 6.5.2 has been released. |
|
You can backport this now, no risk in doing so, and no need to wait IMO. |
|
Thanks @jasontedor for checking. I've backported the bug fix to the 6.5 branch. |
martijnvg
added
v5.6.3
v6.5.3
v6.5.2
and removed
v6.5.2
v5.6.3
backport pending
v6.5.3
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an extra check that verifies that all primary shards
have been started of an index that is about to be auto followed.
If not all primary shards have been started for an index
then the next auto follow run will try to follow to auto follow
this index again.
Closes #35480