HLRC: execute watch API #35868
Merged
HLRC: execute watch API #35868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7a462df.
98 tasks
hub-cap
suggested changes
Dec 3, 2018
| @@ -97,6 +101,30 @@ static Request deleteWatch(DeleteWatchRequest deleteWatchRequest) { | |||
| return request; | |||
| } | |||
|
|
|||
| static Request executeWatch(ExecuteWatchRequest executeWatchRequest) throws IOException { | |||
| RequestConverters.EndpointBuilder builder = new RequestConverters.EndpointBuilder() | |||
| .addPathPart("_xpack", "watcher", "watch"); | |||
There was a problem hiding this comment.
these can be .addPathPartAsIs since they are not user supplied.
| RequestConverters.EndpointBuilder builder = new RequestConverters.EndpointBuilder() | ||
| .addPathPart("_xpack", "watcher", "watch"); | ||
| if (executeWatchRequest.getId() != null) { | ||
| builder.addPathPart(executeWatchRequest.getId()); |
There was a problem hiding this comment.
addPathPart wont "build" anything thats null, so u can just call it instead of checking for null.
|
|
||
| request.setActionMode("action1", ExecuteWatchRequest.ActionExecutionMode.SIMULATE); | ||
|
|
||
| String triggerData = "{ \"entry1\" : \"blah\", \"entry2\" : \"blah\" }"; |
There was a problem hiding this comment.
are these mandatory? if they can be null pls add some random() here. If they cant be null then pls add them to the constructor as final's if possible :)
...core/src/main/java/org/elasticsearch/xpack/core/watcher/support/xcontent/XContentSource.java
Show resolved
Hide resolved
|
Thanks @hub-cap, I pushed some changes to address your comments. |
hub-cap
approved these changes
Dec 4, 2018
| builder.addPathPart(executeWatchRequest.getId()); | ||
| } | ||
| .addPathPartAsIs("_xpack", "watcher", "watch"); | ||
| builder.addPathPart(executeWatchRequest.getId()); // will ignore if ID is null |
There was a problem hiding this comment.
String endpoint = new RequestConverters.EndpointBuilder()
.addPathPartAsIs("_xpack", "watcher", "watch")
.addPathPart(...getId())
.addPathPartAsIs("_execute").build()
|
run the gradle build tests 2 |
romseygeek
added a commit
that referenced
this pull request
Dec 5, 2018
This change adds support for the execute watch API in the high level rest client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #29827