[Zen2] fix NodeJoinTests#testConcurrentJoining() #36033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we sometimes create a setup in which the node is a quorum on its own, which allows it to win a pre-voting round and schedule an election essentially at will, causing it to discard all the joins it just received and fail the test. This change excludes this case, preventing stray elections from ruining things.
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed |
|
@elasticmachine run the Gradle build tests 2 |
DaveCTurner
added a commit
that referenced
this pull request
Dec 1, 2018
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Dec 1, 2018
In elastic#36033 we removed a catch block because we thought we were preventing exceptions by avoiding concurrent elections, missing the obvious fact that some joins are supposed to be failing. As a quick fix the catch was reinstated in 3a5dab6 but this change adds finesse by only catching exceptions from the joins that we expect to fail. It also inlines an always-false parameter to `initialState()`.
DaveCTurner
added a commit
that referenced
this pull request
Dec 1, 2018
In #36033 we removed a catch block because we thought we were preventing exceptions by avoiding concurrent elections, missing the obvious fact that some joins are supposed to be failing. As a quick fix the catch was reinstated in 3a5dab6 but this change adds finesse by only catching exceptions from the joins that we expect to fail. It also inlines an always-false parameter to `initialState()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we sometimes create a setup in which the node is a quorum on its own,
which allows it to win a pre-voting round and schedule an election essentially
at will, causing it to discard all the joins it just received and fail the
test. This change excludes this case, preventing stray elections from ruining
things.